-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev merge #59
Dev merge #59
Conversation
Course now refers to a creator instead of a user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the integration team should align the naming of the exported models, because some are just called for example 'component' but others are called 'userModel'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Der er nogle filer jeg føler der lige skal dobbeltjekkes, men ikke sikkert det er noget der skal holde pull request tilbage... 😄
applications/content-creator-applications/domain/notInUseTest_contentCreatorApplication.js
Outdated
Show resolved
Hide resolved
Agreed. Let's bring this up and make changes in the next sprint |
I have made some updates and simply replied to some comments. Take a look to see if you agree 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with comments by @Jatewo, and considerations.
I approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Description
Added functionality for editing of user accounts, getting courses, and updated the course model.
Changes
Merging of pull requests:
Checklist
Notes for Reviewers